Skip to content

Refactor cat-file batch operations and support --batch-command approach#35775

Merged
lunny merged 11 commits intogo-gitea:mainfrom
wxiaoguang:catfile-test
Jan 8, 2026
Merged

Refactor cat-file batch operations and support --batch-command approach#35775
lunny merged 11 commits intogo-gitea:mainfrom
wxiaoguang:catfile-test

Conversation

@wxiaoguang
Copy link
Copy Markdown
Contributor

@wxiaoguang wxiaoguang commented Oct 29, 2025

Replace #34651 and address more problems including fix framework bugs

Necessary information is written as comments in code.


For reviewers: the largely added code is almost from legacy code, or is covered by tests. The focus can be on the changed code (for example: changing to QueryInfo and QueryContent calls)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 29, 2025
@wxiaoguang wxiaoguang marked this pull request as draft October 29, 2025 17:14
@wxiaoguang wxiaoguang closed this Oct 30, 2025
@wxiaoguang wxiaoguang reopened this Oct 30, 2025
@wxiaoguang wxiaoguang force-pushed the catfile-test branch 2 times, most recently from 6ee7586 to b82d748 Compare October 30, 2025 11:34
@wxiaoguang wxiaoguang closed this Oct 30, 2025
@wxiaoguang wxiaoguang reopened this Oct 30, 2025
@wxiaoguang wxiaoguang closed this Oct 30, 2025
@wxiaoguang wxiaoguang reopened this Jan 7, 2026
# Conflicts:
#	modules/git/blob_nogogit.go
#	modules/git/catfile_batch_reader.go
#	modules/git/languagestats/language_stats_nogogit.go
#	modules/git/repo_base_nogogit.go
#	modules/git/repo_branch_nogogit.go
#	modules/git/repo_commit_nogogit.go
#	modules/git/repo_tag_nogogit.go
#	modules/git/repo_tree_nogogit.go
#	modules/git/tree_entry_nogogit.go
#	modules/git/tree_nogogit.go
#	modules/indexer/code/bleve/bleve.go
#	modules/indexer/code/elasticsearch/elasticsearch.go
@wxiaoguang wxiaoguang force-pushed the catfile-test branch 3 times, most recently from 7856d5a to 1cf64eb Compare January 7, 2026 13:23
@wxiaoguang wxiaoguang force-pushed the catfile-test branch 3 times, most recently from edab0e1 to a409f9b Compare January 7, 2026 15:28
@wxiaoguang wxiaoguang changed the title Refactor cat-file batch operations Refactor cat-file batch operations and support --batch-command approach Jan 7, 2026
@wxiaoguang wxiaoguang marked this pull request as ready for review January 7, 2026 16:59
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Jan 7, 2026
@wxiaoguang wxiaoguang added this to the 1.26.0 milestone Jan 7, 2026
Comment thread modules/git/catfile_batch_reader.go
Comment thread modules/git/repo_base_nogogit.go
Comment thread modules/graceful/manager.go
Comment thread modules/git/blob_nogogit.go
Comment thread modules/git/catfile_batch_command.go
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 8, 2026
@wxiaoguang
Copy link
Copy Markdown
Contributor Author

Why you just copy & paste the same comment for 4 times ....... if there are more implementations in the future (say, your HTTP implementation), would you copy it 8 times or even more?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 8, 2026
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 8, 2026
@lunny lunny merged commit e226720 into go-gitea:main Jan 8, 2026
24 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 8, 2026
@wxiaoguang wxiaoguang deleted the catfile-test branch January 8, 2026 23:10
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 13, 2026
* giteaofficial/main:
  fill missing `has_code` in repository api (go-gitea#36338)
  Fix notifications pagination query parameters (go-gitea#36351)
  Fix cancel auto merge bug (go-gitea#36341)
  Bump appleboy/git-push-action from 1.0.0 to 1.2.0 (go-gitea#36306)
  Improve diff file headers (go-gitea#36215)
  Fix delete attachment check (go-gitea#36320)
  [skip ci] Updated translations via Crowdin
  LFS locks must belong to the intended repo (go-gitea#36344)
  Update chroma to v2.22.0 (go-gitea#36342)
  Update goldmark to v1.7.16 (go-gitea#36343)
  Fix some trivial problems (go-gitea#36336)
  Fix diff view style handling (go-gitea#36324)
  Refactor cat-file batch operations and support `--batch-command` approach (go-gitea#35775)
  Fix file-tree ui error when adding files to repo without commits (go-gitea#36312)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants